Refactor prov-cipher to avoid using deprecated ENGINE/EVP_CIPHER_meth APIs by Mironenko · Pull Request #523 · gost-engine/engine

Mironenko · 2026-04-13T11:17:04Z

This PR introduces a new cipher abstraction layer and removes dependencies on deprecated ENGINE-based interfaces.

Introduce GOST_cipher_ctx to replace EVP_CIPHER_CTX in cipher methods. The corresponding functions mirror the behavior of the EVP_CIPHER_CTX-based APIs. High-level functions GOST_CipherInit_ex, GOST_CipherUpdate, and GOST_CipherFinal are modeled after their EVP counterparts.
Provide a separate GOST_cipher_ctx implementation for the engine target as a wrapper around EVP_CIPHER_CTX.
Introduce the GOST_cipher interface to replace EVP_CIPHER. Its fields are not intended to be accessed directly.
Remove ENGINE initialization from gost_prov initialization.
Add patches for OpenSSL 3.6 to improve test coverage: fix ASN1_item_verify_ctx and x509_sig_info_init to work correctly with provided digests. Without these patches, CA functionality is not available when using OpenSSL 3.6.

Additional fixes:

Fix DER-encoded ASN.1 cipher parameter handling in gost_prov_cipher.
Fix error propagation in magma_get_asn1_parameters(): return an error if gost2015_get_asn1_params() fails.

This PR addresses several issues: resolves #501, resolves #504, resolves #506.

… APIs This commit introduces a new cipher abstraction layer and removes dependencies on deprecated ENGINE-based interfaces. * Introduce `GOST_cipher_ctx` to replace `EVP_CIPHER_CTX` in cipher methods. The corresponding functions mirror the behavior of the `EVP_CIPHER_CTX`-based APIs. High-level functions `GOST_CipherInit_ex`, `GOST_CipherUpdate`, and `GOST_CipherFinal` are modeled after their EVP counterparts. * Provide a separate `GOST_cipher_ctx` implementation for the engine target as a wrapper around `EVP_CIPHER_CTX`. * Introduce the `GOST_cipher` interface to replace `EVP_CIPHER`. Its fields are not intended to be accessed directly. * Remove ENGINE initialization from `gost_prov` initialization. * Add patches for OpenSSL 3.6 to improve test coverage: fix `ASN1_item_verify_ctx` and `x509_sig_info_init` to work correctly with provided digests. Without these patches, CA functionality is not available when using OpenSSL 3.6. Additional fixes: * Fix DER-encoded ASN.1 cipher parameter handling in `gost_prov_cipher`. * Fix error propagation in `magma_get_asn1_parameters()`: return an error if `gost2015_get_asn1_params()` fails.

Copilot

Pull request overview

This PR refactors the cipher implementation to remove provider-side dependencies on deprecated ENGINE/EVP cipher method APIs by introducing an internal GOST_cipher descriptor plus a provider-native GOST_cipher_ctx, while keeping an ENGINE-target wrapper path for legacy integrations. It also adds OpenSSL 3.6 patch files intended to restore CA-related behavior when using provided digests.

Changes:

Introduce GOST_cipher and GOST_cipher_ctx abstractions and refactor cipher implementations to use them (provider-native, with an EVP-wrapping implementation for the engine build).
Update the provider cipher implementation to use GOST_CipherInit_ex/GOST_CipherUpdate/GOST_CipherFinal and remove ENGINE initialization from provider startup.
Add CI scripts and patch files for OpenSSL 3.6 to improve x509/ASN.1 behavior with fetched digests, plus expand cipher tests around provider parameters.

Reviewed changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
test_ciphers.c	Adds provider-specific regression checks for cipher params and padded decrypt behavior.
patches/openssl-x509_sig_info_init.patch	Adds digest fetching fallback in OpenSSL x509 signature info init (patch file).
patches/openssl-asn1_item_verify_ctx.patch	Adds digest fetching fallback in OpenSSL ASN.1 verify ctx path (patch file).
gost_prov.h	Removes ENGINE dependency from provider context header and updates includes.
gost_prov.c	Removes ENGINE creation/teardown from provider initialization and teardown.
gost_prov_cipher.c	Refactors provider cipher plumbing to use `GOST_cipher` + `GOST_cipher_ctx` instead of EVP/ENGINE.
gost_lcl.h	Moves `GOST_cipher` definition out (now via new headers) and updates includes.
gost_keyexpimp.c	Updates cipher wrapper init/do/ctrl signatures to use `GOST_cipher_ctx`.
gost_grasshopper_cipher.h	Updates grasshopper cipher function signatures to use `GOST_cipher_ctx`.
gost_grasshopper_cipher.c	Refactors grasshopper cipher implementation to use `GOST_cipher_ctx` accessors.
gost_gost2015.h	Updates `gost2015_final_call` signature to accept `GOST_cipher_ctx`.
gost_gost2015.c	Implements updated `gost2015_final_call` signature and uses `GOST_cipher_ctx_encrypting`.
gost_eng.c	Switches engine cipher registry to `GOST_eng_cipher` wrapper instances.
gost_eng_cipher.h	Introduces engine-only wrapper API for exposing `GOST_cipher` as `EVP_CIPHER`.
gost_eng_cipher.c	Implements engine-only `EVP_CIPHER` wrappers backed by `GOST_cipher` descriptors.
gost_crypt.c	Refactors gost/magma cipher implementations to use `GOST_cipher_ctx` accessors.
gost_cipher.h	Adds public(ish) accessor API for treating `GOST_cipher` as opaque.
gost_cipher.c	Implements `GOST_cipher` accessors and template field resolution.
gost_cipher_details.h	Defines the internal `struct gost_cipher_st` layout (opaque to external users).
gost_cipher_ctx.h	Declares provider-native cipher context API and accessors.
gost_cipher_ctx.c	Implements provider-native `GOST_cipher_ctx` (EVP-like behavior without EVP types).
gost_cipher_ctx_evp.c	Implements engine-target `GOST_cipher_ctx` as a thin wrapper over `EVP_CIPHER_CTX`.
CMakeLists.txt	Adjusts build composition: provider no longer links engine sources; adds new cipher/ctx sources.
.github/workflows/windows.yml	Applies new OpenSSL patch files in Windows CI.
.github/before_script.sh	Applies new OpenSSL patch files in CI bootstrap script.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-13T12:35:26Z

    if ((p = OSSL_PARAM_locate(params, "alg_id_param")) != NULL) {
        ASN1_TYPE *algidparam = NULL;
        unsigned char *der = NULL;
        int derlen = 0;
        int ret;

        ret = (algidparam = ASN1_TYPE_new()) != NULL
-            && EVP_CIPHER_param_to_asn1(gctx->cctx, algidparam) > 0
+            && (GOST_cipher_set_asn1_parameters_fn(gctx->cipher) == NULL
+                || GOST_cipher_set_asn1_parameters_fn(gctx->cipher)(gctx->cctx,
+                                                                    algidparam) > 0)
            && (derlen = i2d_ASN1_TYPE(algidparam, &der)) >= 0
-            && OSSL_PARAM_set_octet_string(p, &der, (size_t)derlen);
+            && OSSL_PARAM_set_octet_string(p, der, (size_t)derlen);

        OPENSSL_free(der);
        ASN1_TYPE_free(algidparam);


i2d_ASN1_TYPE(algidparam, &der) advances der to the end of the encoded buffer when allocating. The current code passes this advanced pointer to OSSL_PARAM_set_octet_string() and then frees it, which can both return incorrect bytes and call OPENSSL_free() on a non-base pointer. Preserve the original allocated pointer (e.g., unsigned char *der = NULL, *derp = NULL; derp = der; i2d(...,&derp);) and free the base pointer after setting the param.

I don't think this is an issue.

According to the OpenSSL documentation:
https://docs.openssl.org/3.1/man3/d2i_X509/#description

If *ppout is NULL, memory will be allocated for a buffer and the encoded data written to it. In this case *ppout is not incremented and it points to the start of the data just written.

In our case, der is initialized to NULL and we pass &der to
i2d_ASN1_TYPE(). Therefore, the function allocates a new buffer and
assigns its base address to der without advancing the pointer.

As a result, der always points to the beginning of the allocated
buffer, and it is safe to pass it to OSSL_PARAM_set_octet_string() and
later free it with OPENSSL_free().

Copilot · 2026-04-13T12:35:27Z

+
+    if (in->cipher_data && GOST_cipher_ctx_size(in->cipher)) {
+        out->cipher_data = OPENSSL_malloc(GOST_cipher_ctx_size(in->cipher));
+        if (out->cipher_data == NULL) {


GOST_cipher_ctx_copy() does memcpy(out, in, ...) before allocating a new out->cipher_data. If that allocation fails, it sets out->cipher = NULL but leaves out->cipher_data still pointing at in->cipher_data (copied by the memcpy). When the destination context is later freed/reset, it will OPENSSL_free(out->cipher_data), potentially freeing the source context’s memory (double-free / UAF). Ensure out->cipher_data is set to NULL (or restored) on allocation failure before returning, and avoid leaving out in a state where it owns pointers copied from in.

Suggested change

if (out->cipher_data == NULL) {

if (out->cipher_data == NULL) {

out->cipher_data = NULL;

This looks like a mistaken suggestion from Copilot. The proposed change effectively reduces to something like:

if (x == NULL) { x = NULL; }

which does not change the state and therefore does not address the reported issue.

The current behavior is consistent with the original implementation of EVP_CIPHER_CTX_copy():
https://github.com/openssl/openssl/blob/openssl-3.6.0/crypto/evp/evp_enc.c#L1827

Our implementation follows the same pattern, including the handling of allocation failures.

Mironenko · 2026-04-13T13:49:28Z

@chipitsine, I'm sorry for responding to Copilot's comments separately rather than in a single review. It looks like Copilot is mostly mistaken this time.

chipitsine · 2026-04-17T16:01:07Z

there were several "issues" found by coverity (only first 10 sent via email)

Please find the latest report on new defect(s) introduced to gost-engine found with Coverity Scan.

New Defects Found: 22
Defects Shown: Showing 20 of 22 defect(s)
Defect Details
** CID 645650:       Error handling issues  (NEGATIVE_RETURNS)
/gost_crypt.c: 1416           in gost89_get_asn1_parameters()


_____________________________________________________________________________________________
*** CID 645650:         Error handling issues  (NEGATIVE_RETURNS)
/gost_crypt.c: 1416             in gost89_get_asn1_parameters()
1410     
1411         if (!gost_cipher_set_param(c, nid)) {
1412             GOST_CIPHER_PARAMS_free(gcp);
1413             return -1;
1414         }
1415         /*XXX missing non-const accessor */
>>>     CID 645650:         Error handling issues  (NEGATIVE_RETURNS)
>>>     "GOST_cipher_ctx_iv_length(ctx)" is passed to a parameter that cannot be negative.
1416         memcpy((unsigned char *)GOST_cipher_ctx_original_iv(ctx), gcp->iv->data,
1417                GOST_cipher_ctx_iv_length(ctx));
1418     
1419         GOST_CIPHER_PARAMS_free(gcp);
1420     
1421         return 1;

** CID 645649:         (OVERRUN)
/gost_crypt.c: 371           in gost_cipher_init_param()
/gost_crypt.c: 368           in gost_cipher_init_param()


_____________________________________________________________________________________________
*** CID 645649:           (OVERRUN)
/gost_crypt.c: 371             in gost_cipher_init_param()
365         if (key)
366             gost_key(&(c->cctx), key);
367         if (iv) {
368             memcpy((unsigned char *)GOST_cipher_ctx_original_iv(ctx), iv,
369                    GOST_cipher_ctx_iv_length(ctx));
370         }
>>>     CID 645649:           (OVERRUN)
>>>     Calling "memcpy" with "GOST_cipher_ctx_original_iv(ctx)" and "GOST_cipher_ctx_iv_length(ctx)" is suspicious because of the very large index, 18446744073709551615. The index may be due to a negative parameter being interpreted as unsigned.
371         memcpy(GOST_cipher_ctx_iv_noconst(ctx),
372                GOST_cipher_ctx_original_iv(ctx), GOST_cipher_ctx_iv_length(ctx));
373         return 1;
374     }
375     
376     static int gost_cipher_init_cnt(GOST_cipher_ctx *ctx,
/gost_crypt.c: 368             in gost_cipher_init_param()
362                 return 0;
363             GOST_cipher_ctx_set_app_data(ctx, GOST_cipher_ctx_get_cipher_data(ctx));
364         }
365         if (key)
366             gost_key(&(c->cctx), key);
367         if (iv) {
>>>     CID 645649:           (OVERRUN)
>>>     Calling "memcpy" with "(unsigned char *)GOST_cipher_ctx_original_iv(ctx)" and "GOST_cipher_ctx_iv_length(ctx)" is suspicious because of the very large index, 18446744073709551615. The index may be due to a negative parameter being interpreted as unsigned.
368             memcpy((unsigned char *)GOST_cipher_ctx_original_iv(ctx), iv,
369                    GOST_cipher_ctx_iv_length(ctx));
370         }
371         memcpy(GOST_cipher_ctx_iv_noconst(ctx),
372                GOST_cipher_ctx_original_iv(ctx), GOST_cipher_ctx_iv_length(ctx));
373         return 1;

** CID 645648:         (NEGATIVE_RETURNS)
/gost_grasshopper_cipher.c: 259           in gost_grasshopper_cipher_init()
/gost_grasshopper_cipher.c: 263           in gost_grasshopper_cipher_init()


_____________________________________________________________________________________________
*** CID 645648:           (NEGATIVE_RETURNS)
/gost_grasshopper_cipher.c: 259             in gost_grasshopper_cipher_init()
253         if (key != NULL) {
254             gost_grasshopper_cipher_key(c, key);
255             gost_grasshopper_master_key(c, key);
256         }
257     
258         if (iv != NULL) {
>>>     CID 645648:           (NEGATIVE_RETURNS)
>>>     "GOST_cipher_ctx_iv_length(ctx)" is passed to a parameter that cannot be negative.
259             memcpy((unsigned char *)GOST_cipher_ctx_original_iv(ctx), iv,
260                    GOST_cipher_ctx_iv_length(ctx));
261         }
262     
263         memcpy(GOST_cipher_ctx_iv_noconst(ctx),
264                GOST_cipher_ctx_original_iv(ctx), GOST_cipher_ctx_iv_length(ctx));
/gost_grasshopper_cipher.c: 263             in gost_grasshopper_cipher_init()
257     
258         if (iv != NULL) {
259             memcpy((unsigned char *)GOST_cipher_ctx_original_iv(ctx), iv,
260                    GOST_cipher_ctx_iv_length(ctx));
261         }
262     
>>>     CID 645648:           (NEGATIVE_RETURNS)
>>>     "GOST_cipher_ctx_iv_length(ctx)" is passed to a parameter that cannot be negative.
263         memcpy(GOST_cipher_ctx_iv_noconst(ctx),
264                GOST_cipher_ctx_original_iv(ctx), GOST_cipher_ctx_iv_length(ctx));
265     
266         grasshopper_zero128(&c->buffer);
267     
268         return 1;

** CID 645647:         (OVERRUN)
/gost_crypt.c: 450           in magma_cipher_init()
/gost_crypt.c: 447           in magma_cipher_init()


_____________________________________________________________________________________________
*** CID 645647:           (OVERRUN)
/gost_crypt.c: 450             in magma_cipher_init()
444             magma_master_key(&(c->cctx), key);
445         }
446         if (iv) {
447             memcpy((unsigned char *)GOST_cipher_ctx_original_iv(ctx), iv,
448                    GOST_cipher_ctx_iv_length(ctx));
449         }
>>>     CID 645647:           (OVERRUN)
>>>     Calling "memcpy" with "GOST_cipher_ctx_original_iv(ctx)" and "GOST_cipher_ctx_iv_length(ctx)" is suspicious because of the very large index, 18446744073709551615. The index may be due to a negative parameter being interpreted as unsigned.
450         memcpy(GOST_cipher_ctx_iv_noconst(ctx),
451                GOST_cipher_ctx_original_iv(ctx), GOST_cipher_ctx_iv_length(ctx));
452     
453         if (GOST_cipher_ctx_nid(ctx) == NID_magma_ctr_acpkm
454          || GOST_cipher_ctx_nid(ctx) == NID_magma_ctr_acpkm_omac) {
455            c->key_meshing = 1024;
/gost_crypt.c: 447             in magma_cipher_init()
441     
442         if (key) {
443             magma_key(&(c->cctx), key);
444             magma_master_key(&(c->cctx), key);
445         }
446         if (iv) {
>>>     CID 645647:           (OVERRUN)
>>>     Calling "memcpy" with "(unsigned char *)GOST_cipher_ctx_original_iv(ctx)" and "GOST_cipher_ctx_iv_length(ctx)" is suspicious because of the very large index, 18446744073709551615. The index may be due to a negative parameter being interpreted as unsigned.
447             memcpy((unsigned char *)GOST_cipher_ctx_original_iv(ctx), iv,
448                    GOST_cipher_ctx_iv_length(ctx));
449         }
450         memcpy(GOST_cipher_ctx_iv_noconst(ctx),
451                GOST_cipher_ctx_original_iv(ctx), GOST_cipher_ctx_iv_length(ctx));
452     

** CID 645646:       Memory - corruptions  (OVERRUN)
/gost_crypt.c: 371           in gost_cipher_init_param()


_____________________________________________________________________________________________
*** CID 645646:         Memory - corruptions  (OVERRUN)
/gost_crypt.c: 371             in gost_cipher_init_param()
365         if (key)
366             gost_key(&(c->cctx), key);
367         if (iv) {
368             memcpy((unsigned char *)GOST_cipher_ctx_original_iv(ctx), iv,
369                    GOST_cipher_ctx_iv_length(ctx));
370         }
>>>     CID 645646:         Memory - corruptions  (OVERRUN)
>>>     Calling "memcpy" with "GOST_cipher_ctx_iv_noconst(ctx)" and "GOST_cipher_ctx_iv_length(ctx)" is suspicious because of the very large index, 18446744073709551615. The index may be due to a negative parameter being interpreted as unsigned.
371         memcpy(GOST_cipher_ctx_iv_noconst(ctx),
372                GOST_cipher_ctx_original_iv(ctx), GOST_cipher_ctx_iv_length(ctx));
373         return 1;
374     }
375     
376     static int gost_cipher_init_cnt(GOST_cipher_ctx *ctx,

** CID 645645:       Memory - corruptions  (OVERRUN)
/gost_crypt.c: 447           in magma_cipher_init()


_____________________________________________________________________________________________
*** CID 645645:         Memory - corruptions  (OVERRUN)
/gost_crypt.c: 447             in magma_cipher_init()
441     
442         if (key) {
443             magma_key(&(c->cctx), key);
444             magma_master_key(&(c->cctx), key);
445         }
446         if (iv) {
>>>     CID 645645:         Memory - corruptions  (OVERRUN)
>>>     Calling "memcpy" with "iv" and "GOST_cipher_ctx_iv_length(ctx)" is suspicious because of the very large index, 18446744073709551615. The index may be due to a negative parameter being interpreted as unsigned.
447             memcpy((unsigned char *)GOST_cipher_ctx_original_iv(ctx), iv,
448                    GOST_cipher_ctx_iv_length(ctx));
449         }
450         memcpy(GOST_cipher_ctx_iv_noconst(ctx),
451                GOST_cipher_ctx_original_iv(ctx), GOST_cipher_ctx_iv_length(ctx));
452     

** CID 645644:       Integer handling issues  (NEGATIVE_RETURNS)


_____________________________________________________________________________________________
*** CID 645644:         Integer handling issues  (NEGATIVE_RETURNS)
/gost_grasshopper_cipher.c: 500             in gost_grasshopper_cipher_init_mgm()
494             /*
495              * If we have an iv can set it directly, otherwise use saved IV.
496              */
497             if (iv == NULL && mctx->iv_set)
498                 iv = mctx->iv;
499             if (iv) {
>>>     CID 645644:         Integer handling issues  (NEGATIVE_RETURNS)
>>>     "mctx->mgm.blocklen" is passed to a parameter that cannot be negative.
500                 if (gost_mgm128_setiv(&mctx->mgm, iv, mctx->ivlen) != 1)
501                     return 0;
502                 mctx->iv_set = 1;
503             }
504             mctx->key_set = 1;
505         } else {

** CID 645643:       Memory - corruptions  (OVERRUN)
/gost_grasshopper_cipher.c: 263           in gost_grasshopper_cipher_init()


_____________________________________________________________________________________________
*** CID 645643:         Memory - corruptions  (OVERRUN)
/gost_grasshopper_cipher.c: 263             in gost_grasshopper_cipher_init()
257     
258         if (iv != NULL) {
259             memcpy((unsigned char *)GOST_cipher_ctx_original_iv(ctx), iv,
260                    GOST_cipher_ctx_iv_length(ctx));
261         }
262     
>>>     CID 645643:         Memory - corruptions  (OVERRUN)
>>>     Calling "memcpy" with "GOST_cipher_ctx_iv_noconst(ctx)" and "GOST_cipher_ctx_iv_length(ctx)" is suspicious because of the very large index, 18446744073709551615. The index may be due to a negative parameter being interpreted as unsigned.
263         memcpy(GOST_cipher_ctx_iv_noconst(ctx),
264                GOST_cipher_ctx_original_iv(ctx), GOST_cipher_ctx_iv_length(ctx));
265     
266         grasshopper_zero128(&c->buffer);
267     
268         return 1;

** CID 645642:       Memory - corruptions  (OVERRUN)
/gost_grasshopper_cipher.c: 259           in gost_grasshopper_cipher_init()


_____________________________________________________________________________________________
*** CID 645642:         Memory - corruptions  (OVERRUN)
/gost_grasshopper_cipher.c: 259             in gost_grasshopper_cipher_init()
253         if (key != NULL) {
254             gost_grasshopper_cipher_key(c, key);
255             gost_grasshopper_master_key(c, key);
256         }
257     
258         if (iv != NULL) {
>>>     CID 645642:         Memory - corruptions  (OVERRUN)
>>>     Calling "memcpy" with "iv" and "GOST_cipher_ctx_iv_length(ctx)" is suspicious because of the very large index, 18446744073709551615. The index may be due to a negative parameter being interpreted as unsigned.
259             memcpy((unsigned char *)GOST_cipher_ctx_original_iv(ctx), iv,
260                    GOST_cipher_ctx_iv_length(ctx));
261         }
262     
263         memcpy(GOST_cipher_ctx_iv_noconst(ctx),
264                GOST_cipher_ctx_original_iv(ctx), GOST_cipher_ctx_iv_length(ctx));

** CID 645641:       Memory - corruptions  (OVERRUN)
/gost_crypt.c: 1416           in gost89_get_asn1_parameters()


_____________________________________________________________________________________________
*** CID 645641:         Memory - corruptions  (OVERRUN)
/gost_crypt.c: 1416             in gost89_get_asn1_parameters()
1410     
1411         if (!gost_cipher_set_param(c, nid)) {
1412             GOST_CIPHER_PARAMS_free(gcp);
1413             return -1;
1414         }
1415         /*XXX missing non-const accessor */
>>>     CID 645641:         Memory - corruptions  (OVERRUN)
>>>     Calling "memcpy" with "(unsigned char *)GOST_cipher_ctx_original_iv(ctx)" and "GOST_cipher_ctx_iv_length(ctx)" is suspicious because of the very large index, 18446744073709551615. The index may be due to a negative parameter being interpreted as unsigned.
1416         memcpy((unsigned char *)GOST_cipher_ctx_original_iv(ctx), gcp->iv->data,
1417                GOST_cipher_ctx_iv_length(ctx));
1418     
1419         GOST_CIPHER_PARAMS_free(gcp);
1420     
1421         return 1;

** CID 645640:       Memory - corruptions  (OVERRUN)
/gost_crypt.c: 368           in gost_cipher_init_param()


_____________________________________________________________________________________________
*** CID 645640:         Memory - corruptions  (OVERRUN)
/gost_crypt.c: 368             in gost_cipher_init_param()
362                 return 0;
363             GOST_cipher_ctx_set_app_data(ctx, GOST_cipher_ctx_get_cipher_data(ctx));
364         }
365         if (key)
366             gost_key(&(c->cctx), key);
367         if (iv) {
>>>     CID 645640:         Memory - corruptions  (OVERRUN)
>>>     Calling "memcpy" with "iv" and "GOST_cipher_ctx_iv_length(ctx)" is suspicious because of the very large index, 18446744073709551615. The index may be due to a negative parameter being interpreted as unsigned.
368             memcpy((unsigned char *)GOST_cipher_ctx_original_iv(ctx), iv,
369                    GOST_cipher_ctx_iv_length(ctx));
370         }
371         memcpy(GOST_cipher_ctx_iv_noconst(ctx),
372                GOST_cipher_ctx_original_iv(ctx), GOST_cipher_ctx_iv_length(ctx));
373         return 1;

** CID 645639:       Memory - corruptions  (OVERRUN)
/gost_crypt.c: 450           in magma_cipher_init()


_____________________________________________________________________________________________
*** CID 645639:         Memory - corruptions  (OVERRUN)
/gost_crypt.c: 450             in magma_cipher_init()
444             magma_master_key(&(c->cctx), key);
445         }
446         if (iv) {
447             memcpy((unsigned char *)GOST_cipher_ctx_original_iv(ctx), iv,
448                    GOST_cipher_ctx_iv_length(ctx));
449         }
>>>     CID 645639:         Memory - corruptions  (OVERRUN)
>>>     Calling "memcpy" with "GOST_cipher_ctx_iv_noconst(ctx)" and "GOST_cipher_ctx_iv_length(ctx)" is suspicious because of the very large index, 18446744073709551615. The index may be due to a negative parameter being interpreted as unsigned.
450         memcpy(GOST_cipher_ctx_iv_noconst(ctx),
451                GOST_cipher_ctx_original_iv(ctx), GOST_cipher_ctx_iv_length(ctx));
452     
453         if (GOST_cipher_ctx_nid(ctx) == NID_magma_ctr_acpkm
454          || GOST_cipher_ctx_nid(ctx) == NID_magma_ctr_acpkm_omac) {
455            c->key_meshing = 1024;

** CID 645638:       Integer handling issues  (NEGATIVE_RETURNS)


_____________________________________________________________________________________________
*** CID 645638:         Integer handling issues  (NEGATIVE_RETURNS)
/gost_crypt.c: 581             in gost_magma_cipher_init_mgm()
575             /*
576              * If we have an iv can set it directly, otherwise use saved IV.
577              */
578             if (iv == NULL && mctx->iv_set)
579                 iv = mctx->iv;
580             if (iv) {
>>>     CID 645638:         Integer handling issues  (NEGATIVE_RETURNS)
>>>     "mctx->mgm.blocklen" is passed to a parameter that cannot be negative.
581                 if (gost_mgm128_setiv(&mctx->mgm, iv, mctx->ivlen) != 1)
582                     return 0;
583                 mctx->iv_set = 1;
584             }
585             mctx->key_set = 1;
586         } else {

** CID 645637:       Memory - corruptions  (OVERRUN)
/gost_crypt.c: 1416           in gost89_get_asn1_parameters()


_____________________________________________________________________________________________
*** CID 645637:         Memory - corruptions  (OVERRUN)
/gost_crypt.c: 1416             in gost89_get_asn1_parameters()
1410     
1411         if (!gost_cipher_set_param(c, nid)) {
1412             GOST_CIPHER_PARAMS_free(gcp);
1413             return -1;
1414         }
1415         /*XXX missing non-const accessor */
>>>     CID 645637:         Memory - corruptions  (OVERRUN)
>>>     Calling "memcpy" with "gcp->iv->data" and "GOST_cipher_ctx_iv_length(ctx)" is suspicious because of the very large index, 18446744073709551615. The index may be due to a negative parameter being interpreted as unsigned.
1416         memcpy((unsigned char *)GOST_cipher_ctx_original_iv(ctx), gcp->iv->data,
1417                GOST_cipher_ctx_iv_length(ctx));
1418     
1419         GOST_CIPHER_PARAMS_free(gcp);
1420     
1421         return 1;

** CID 645636:       Memory - corruptions  (OVERRUN)
/gost_crypt.c: 391           in gost_cipher_init_cnt()


_____________________________________________________________________________________________
*** CID 645636:         Memory - corruptions  (OVERRUN)
/gost_crypt.c: 391             in gost_cipher_init_cnt()
385         if (key)
386             gost_key(&(c->cctx), key);
387         if (iv) {
388             memcpy((unsigned char *)GOST_cipher_ctx_original_iv(ctx), iv,
389                    GOST_cipher_ctx_iv_length(ctx));
390         }
>>>     CID 645636:         Memory - corruptions  (OVERRUN)
>>>     Calling "memcpy" with "GOST_cipher_ctx_iv_noconst(ctx)" and "GOST_cipher_ctx_iv_length(ctx)" is suspicious because of the very large index, 18446744073709551615. The index may be due to a negative parameter being interpreted as unsigned.
391         memcpy(GOST_cipher_ctx_iv_noconst(ctx),
392                GOST_cipher_ctx_original_iv(ctx), GOST_cipher_ctx_iv_length(ctx));
393         return 1;
394     }
395     
396     static int gost_cipher_init_cpa(GOST_cipher_ctx *ctx, const unsigned char *key,

** CID 645635:         (NEGATIVE_RETURNS)
/gost_crypt.c: 388           in gost_cipher_init_cnt()
/gost_crypt.c: 391           in gost_cipher_init_cnt()


_____________________________________________________________________________________________
*** CID 645635:           (NEGATIVE_RETURNS)
/gost_crypt.c: 388             in gost_cipher_init_cnt()
382         gost_init(&(c->cctx), block);
383         c->key_meshing = 1;
384         c->count = 0;
385         if (key)
386             gost_key(&(c->cctx), key);
387         if (iv) {
>>>     CID 645635:           (NEGATIVE_RETURNS)
>>>     "GOST_cipher_ctx_iv_length(ctx)" is passed to a parameter that cannot be negative.
388             memcpy((unsigned char *)GOST_cipher_ctx_original_iv(ctx), iv,
389                    GOST_cipher_ctx_iv_length(ctx));
390         }
391         memcpy(GOST_cipher_ctx_iv_noconst(ctx),
392                GOST_cipher_ctx_original_iv(ctx), GOST_cipher_ctx_iv_length(ctx));
393         return 1;
/gost_crypt.c: 391             in gost_cipher_init_cnt()
385         if (key)
386             gost_key(&(c->cctx), key);
387         if (iv) {
388             memcpy((unsigned char *)GOST_cipher_ctx_original_iv(ctx), iv,
389                    GOST_cipher_ctx_iv_length(ctx));
390         }
>>>     CID 645635:           (NEGATIVE_RETURNS)
>>>     "GOST_cipher_ctx_iv_length(ctx)" is passed to a parameter that cannot be negative.
391         memcpy(GOST_cipher_ctx_iv_noconst(ctx),
392                GOST_cipher_ctx_original_iv(ctx), GOST_cipher_ctx_iv_length(ctx));
393         return 1;
394     }
395     
396     static int gost_cipher_init_cpa(GOST_cipher_ctx *ctx, const unsigned char *key,

** CID 645634:         (OVERRUN)
/gost_grasshopper_cipher.c: 263           in gost_grasshopper_cipher_init()
/gost_grasshopper_cipher.c: 259           in gost_grasshopper_cipher_init()


_____________________________________________________________________________________________
*** CID 645634:           (OVERRUN)
/gost_grasshopper_cipher.c: 263             in gost_grasshopper_cipher_init()
257     
258         if (iv != NULL) {
259             memcpy((unsigned char *)GOST_cipher_ctx_original_iv(ctx), iv,
260                    GOST_cipher_ctx_iv_length(ctx));
261         }
262     
>>>     CID 645634:           (OVERRUN)
>>>     Calling "memcpy" with "GOST_cipher_ctx_original_iv(ctx)" and "GOST_cipher_ctx_iv_length(ctx)" is suspicious because of the very large index, 18446744073709551615. The index may be due to a negative parameter being interpreted as unsigned.
263         memcpy(GOST_cipher_ctx_iv_noconst(ctx),
264                GOST_cipher_ctx_original_iv(ctx), GOST_cipher_ctx_iv_length(ctx));
265     
266         grasshopper_zero128(&c->buffer);
267     
268         return 1;
/gost_grasshopper_cipher.c: 259             in gost_grasshopper_cipher_init()
253         if (key != NULL) {
254             gost_grasshopper_cipher_key(c, key);
255             gost_grasshopper_master_key(c, key);
256         }
257     
258         if (iv != NULL) {
>>>     CID 645634:           (OVERRUN)
>>>     Calling "memcpy" with "(unsigned char *)GOST_cipher_ctx_original_iv(ctx)" and "GOST_cipher_ctx_iv_length(ctx)" is suspicious because of the very large index, 18446744073709551615. The index may be due to a negative parameter being interpreted as unsigned.
259             memcpy((unsigned char *)GOST_cipher_ctx_original_iv(ctx), iv,
260                    GOST_cipher_ctx_iv_length(ctx));
261         }
262     
263         memcpy(GOST_cipher_ctx_iv_noconst(ctx),
264                GOST_cipher_ctx_original_iv(ctx), GOST_cipher_ctx_iv_length(ctx));

** CID 645633:         (OVERRUN)
/gost_crypt.c: 388           in gost_cipher_init_cnt()
/gost_crypt.c: 391           in gost_cipher_init_cnt()


_____________________________________________________________________________________________
*** CID 645633:           (OVERRUN)
/gost_crypt.c: 388             in gost_cipher_init_cnt()
382         gost_init(&(c->cctx), block);
383         c->key_meshing = 1;
384         c->count = 0;
385         if (key)
386             gost_key(&(c->cctx), key);
387         if (iv) {
>>>     CID 645633:           (OVERRUN)
>>>     Calling "memcpy" with "(unsigned char *)GOST_cipher_ctx_original_iv(ctx)" and "GOST_cipher_ctx_iv_length(ctx)" is suspicious because of the very large index, 18446744073709551615. The index may be due to a negative parameter being interpreted as unsigned.
388             memcpy((unsigned char *)GOST_cipher_ctx_original_iv(ctx), iv,
389                    GOST_cipher_ctx_iv_length(ctx));
390         }
391         memcpy(GOST_cipher_ctx_iv_noconst(ctx),
392                GOST_cipher_ctx_original_iv(ctx), GOST_cipher_ctx_iv_length(ctx));
393         return 1;
/gost_crypt.c: 391             in gost_cipher_init_cnt()
385         if (key)
386             gost_key(&(c->cctx), key);
387         if (iv) {
388             memcpy((unsigned char *)GOST_cipher_ctx_original_iv(ctx), iv,
389                    GOST_cipher_ctx_iv_length(ctx));
390         }
>>>     CID 645633:           (OVERRUN)
>>>     Calling "memcpy" with "GOST_cipher_ctx_original_iv(ctx)" and "GOST_cipher_ctx_iv_length(ctx)" is suspicious because of the very large index, 18446744073709551615. The index may be due to a negative parameter being interpreted as unsigned.
391         memcpy(GOST_cipher_ctx_iv_noconst(ctx),
392                GOST_cipher_ctx_original_iv(ctx), GOST_cipher_ctx_iv_length(ctx));
393         return 1;
394     }
395     
396     static int gost_cipher_init_cpa(GOST_cipher_ctx *ctx, const unsigned char *key,

** CID 645632:       Memory - corruptions  (OVERRUN)
/gost_crypt.c: 388           in gost_cipher_init_cnt()


_____________________________________________________________________________________________
*** CID 645632:         Memory - corruptions  (OVERRUN)
/gost_crypt.c: 388             in gost_cipher_init_cnt()
382         gost_init(&(c->cctx), block);
383         c->key_meshing = 1;
384         c->count = 0;
385         if (key)
386             gost_key(&(c->cctx), key);
387         if (iv) {
>>>     CID 645632:         Memory - corruptions  (OVERRUN)
>>>     Calling "memcpy" with "iv" and "GOST_cipher_ctx_iv_length(ctx)" is suspicious because of the very large index, 18446744073709551615. The index may be due to a negative parameter being interpreted as unsigned.
388             memcpy((unsigned char *)GOST_cipher_ctx_original_iv(ctx), iv,
389                    GOST_cipher_ctx_iv_length(ctx));
390         }
391         memcpy(GOST_cipher_ctx_iv_noconst(ctx),
392                GOST_cipher_ctx_original_iv(ctx), GOST_cipher_ctx_iv_length(ctx));
393         return 1;

** CID 645631:         (NEGATIVE_RETURNS)
/gost_crypt.c: 450           in magma_cipher_init()
/gost_crypt.c: 447           in magma_cipher_init()


_____________________________________________________________________________________________
*** CID 645631:           (NEGATIVE_RETURNS)
/gost_crypt.c: 450             in magma_cipher_init()
444             magma_master_key(&(c->cctx), key);
445         }
446         if (iv) {
447             memcpy((unsigned char *)GOST_cipher_ctx_original_iv(ctx), iv,
448                    GOST_cipher_ctx_iv_length(ctx));
449         }
>>>     CID 645631:           (NEGATIVE_RETURNS)
>>>     "GOST_cipher_ctx_iv_length(ctx)" is passed to a parameter that cannot be negative.
450         memcpy(GOST_cipher_ctx_iv_noconst(ctx),
451                GOST_cipher_ctx_original_iv(ctx), GOST_cipher_ctx_iv_length(ctx));
452     
453         if (GOST_cipher_ctx_nid(ctx) == NID_magma_ctr_acpkm
454          || GOST_cipher_ctx_nid(ctx) == NID_magma_ctr_acpkm_omac) {
455            c->key_meshing = 1024;
/gost_crypt.c: 447             in magma_cipher_init()
441     
442         if (key) {
443             magma_key(&(c->cctx), key);
444             magma_master_key(&(c->cctx), key);
445         }
446         if (iv) {
>>>     CID 645631:           (NEGATIVE_RETURNS)
>>>     "GOST_cipher_ctx_iv_length(ctx)" is passed to a parameter that cannot be negative.
447             memcpy((unsigned char *)GOST_cipher_ctx_original_iv(ctx), iv,
448                    GOST_cipher_ctx_iv_length(ctx));
449         }
450         memcpy(GOST_cipher_ctx_iv_noconst(ctx),
451                GOST_cipher_ctx_original_iv(ctx), GOST_cipher_ctx_iv_length(ctx));
452

chipitsine requested a review from Copilot April 13, 2026 12:29

Copilot started reviewing on behalf of chipitsine April 13, 2026 12:30 View session

Copilot AI reviewed Apr 13, 2026

View reviewed changes

chipitsine merged commit 4e6e331 into gost-engine:master Apr 13, 2026
16 checks passed

Mironenko mentioned this pull request Apr 18, 2026

Fix static analysis warnings for GOST_cipher_ctx_iv_length returning -1 #525

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor prov-cipher to avoid using deprecated ENGINE/EVP_CIPHER_meth APIs#523

Refactor prov-cipher to avoid using deprecated ENGINE/EVP_CIPHER_meth APIs#523
chipitsine merged 1 commit intogost-engine:masterfrom
Mironenko:prov-cipher

Mironenko commented Apr 13, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 13, 2026

Uh oh!

Mironenko Apr 13, 2026

Uh oh!

Copilot AI Apr 13, 2026

Uh oh!

Mironenko Apr 13, 2026 •

edited

Loading

Uh oh!

Mironenko commented Apr 13, 2026

Uh oh!

Uh oh!

chipitsine commented Apr 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	if (out->cipher_data == NULL) {
	if (out->cipher_data == NULL) {
	out->cipher_data = NULL;

Conversation

Mironenko commented Apr 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

Mironenko Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

Mironenko Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Mironenko commented Apr 13, 2026

Uh oh!

Uh oh!

chipitsine commented Apr 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Mironenko Apr 13, 2026 •

edited

Loading